amarok/HACKING/commitchecklist.txt

0001 The following checklist is supposed to help you make sure you don't forget anything important in a commit.
0002
0003 Before hacking:
0004 * Does it fit Amarok's vision or at least not work against it?
0005 * Who will maintain the code?
0006
0007 Before committing:
0008 * Does it conform to Amarok's coding style?
0009 * Has it been added to the changelog in case of a bug, feature or UI change?
0010 * Does it introduce new dependencies?
0011 * Does the diff contain only the changes you made and files you added/removed? Does it contain all of them?
0012 * Do existing regression tests still pass?
0013 * Does it add new strings? Is Amarok in string freeze?
0014 * Are you pushing a big change that does not fix a bug while Amarok is in beta?
0015 * Is there a feature request, bug report or review request associated with it? (Please close them with the commit message.)
0016
0017 Additionally for commits introducing new features:
0018 * Is Amarok in feature freeze?
0019 * Are new tests needed?
0020 * Has it been reviewed by a usability person?
0021 * Does user documentation exist?