Warning, /graphics/kst-plot/devel-docs/krazy2.out is written in an unsupported language. File is not indexed.

0001 
0002 krazy2 Analysis
0003 
0004 Checkers Run = 45
0005 Files Processed = 778
0006 Total Issues = 629 ...as of June 07 2011 10:33:54 EDT
0007 
0008 ==>For File Type c++<==
0009 1. Check for TRUE and FALSE macros [captruefalse]... Ok!
0010 
0011 2. Check for methods that return 'const' refs in public classes [constref]... Ok!
0012 
0013 3. Check for an acceptable copyright [copyright]... 12 issues found
0014         ./libkstmath/kstmath_pch.h: missing tags: copyright  (1)
0015         ./datasources/dmc/dmcdata.h: missing tags: email address(line 5)  (1)
0016         ./datasources/dmc/dmcsource.cpp: missing tags: email address(line 5)  (1)
0017         ./datasources/dmc/dmcobj.cpp: missing tags: email address(line 6)  (1)
0018         ./datasources/dmc/dmcdata.cpp: missing tags: email address(line 5)  (1)
0019         ./datasources/dmc/dmcsource.h: missing tags: email address(line 5)  (1)
0020         ./datasources/dmc/dmcobj.h: missing tags: email address(line 5)  (1)
0021         ./plugins/dataobject/genericfilter/polynom.h: missing tags: email address(line 7)  (1)
0022         ./plugins/dataobject/genericfilter/filter.h: missing tags: email address(line 7)  (1)
0023         ./widgets/kstwidgets_pch.h: missing tags: copyright  (1)
0024         ./libkst/kstcore_pch.h: missing tags: copyright  (1)
0025         ./libkstapp/kstapp_pch.h: missing tags: copyright  (1)
0026         All source files must contain a copyright header which identifies
0027         the copyright holder(s) together with a e-mail address that can be
0028         used to reach the copyright holder.  One copyright holder per line,
0029         with real email addresses please. For details regarding KDE's
0030         licensing policy please visit
0031         <http://techbase.kde.org/Policies/Licensing_Policy>.  A typical
0032         copyright looks like: "Copyright 2002,2005-2006 Joe Hacker
0033         <joe.hacker@kde.org>"
0034 
0035 4. Check for cpp macros and usage [cpp]... 36 issues found
0036         ./libkstmath/basicplugin.cpp: O/S or Compiler specific macro line#19[Q_WS_WIN32] (1)
0037         ./libkstmath/escan.cpp: O/S or Compiler specific macro line#516[Q_WS_WIN32],1541[Q_WS_WIN32],1568[Q_WS_WIN32] (3)
0038         ./libkstmath/enodes.cpp: O/S or Compiler specific macro line#25[Q_WS_WIN32],390[Q_WS_WIN32] (2)
0039         ./libkstmath/eventmonitorentry.cpp: O/S or Compiler specific macro line#35[Q_WS_WIN32] (1)
0040         ./libkstmath/curve.cpp: O/S or Compiler specific macro line#43[__GNUC__],567[Q_WS_WIN32] (2)
0041         ./libkstmath/labelparser.h: O/S or Compiler specific macro line#67[Q_WS_WIN32] (1)
0042         ./datasources/dmc/dmcsource.cpp: Guard #warning with '#ifdef __GNUC__' line#48,158,327 (3)
0043         ./datasources/dmc/dmcdata.cpp: Guard #warning with '#ifdef __GNUC__' line#48 (1)
0044         ./widgets/curveappearance.cpp: O/S or Compiler specific macro line#452[Q_WS_WIN32] (1)
0045         ./libkst/kst_inf.h: O/S or Compiler specific macro line#21[__sun] (1)
0046         ./libkst/datasourcepluginmanager.cpp: O/S or Compiler specific macro line#315[Q_WS_WIN32],354[Q_WS_WIN32] (2)
0047         ./libkst/psversion.h: O/S or Compiler specific macro line#2[__linux__] (1)
0048         ./libkst/sysinfo.h: O/S or Compiler specific macro line#12[__linux__] (1)
0049         ./libkst/math_kst.h: O/S or Compiler specific macro line#23[__sun],63[__APPLE__],82[__SVR4,__sun],86[Q_WS_WIN32] (4)
0050         ./libkst/ksttimers.h: Unknown HAVE_FOO macro line#18[HAVE_KST_USE_TIMERS] (1)
0051         ./libkst/datacollection.cpp: O/S or Compiler specific macro line#33[__linux__],47[__linux__] (2)
0052         ./libkst/procps.h: O/S or Compiler specific macro line#58[__GNUC__,__GNUC_MINOR__],66[__GNUC__,__GNUC_MINOR__],83[__GNUC__,__GNUC_MINOR__] (3)
0053         ./libkst/procps.h: Guard #warning with '#ifdef __GNUC__' line#61 (1)
0054         ./libkstapp/datawizard.cpp: O/S or Compiler specific macro line#779[__linux__] (1)
0055         ./libkstapp/viewitemdialog.cpp: O/S or Compiler specific macro line#306[Q_WS_WIN32] (1)
0056         ./libkstapp/memorywidget.cpp: O/S or Compiler specific macro line#35[__linux__] (1)
0057         ./libkstapp/bugreportwizard.cpp: O/S or Compiler specific macro line#35[Q_WS_WIN32],37[Q_WS_WIN64] (2)
0058         C++ source files and non-installed headers should NOT use cpp
0059         conditionals that check for a certain O/S or compiler; instead use
0060         CMake HAVE_foo macros. We want to check for features discovered
0061         during CMake time rather than for a specific O/S.
0062 
0063 5. Check for code that should be considered crashy. [crashy]... 1 issue found
0064         ./libkstapp/commandlineparser.cpp: line#128 (1)
0065         Looks for not using QPointers when showing modal dialogs via
0066         exec(), as discussed in <http://www.kdedevelopers.org/node/3919>
0067 
0068 6. Check single-char QString operations for efficiency [doublequote_chars]... 6 issues found
0069         ./plugins/filters/butterworth_bandstop/butterworth_bandstop.cpp: line#26 (1)
0070         ./plugins/filters/butterworth_bandpass/butterworth_bandpass.cpp: line#26 (1)
0071         ./plugins/filters/butterworth_lowpass/butterworth_lowpass.cpp: line#26 (1)
0072         ./plugins/filters/butterworth_highpass/butterworth_highpass.cpp: line#25 (1)
0073         ./plugins/dataobject/correlation/crosscorrelation/crosscorrelation.cpp: line#27 (1)
0074         ./plugins/dataobject/effectivebandwidth/effectivebandwidth.cpp: line#24 (1)
0075         Adding single characters to a QString is faster if the characters
0076         are QChars and not QStrings.  For example: QString path = oldpath +
0077         "/" + base is better written as QString path = oldpath + '/' +
0078         base. Same holds for arguments to QString::startsWith(),
0079         QString::endsWith(), QString::remove(), QString::section(), and
0080         QString::split(). Use QString::remove() instead of
0081         QString::replace(foo,"")
0082 
0083 7. Check for unwanted doxygen tags in major versions [doxytags]... Ok!
0084 
0085 8. Check public classes with private members or d-pointer issues [dpointer]... Ok!
0086 
0087 9. Check for QString compares to "" [emptystrcompare]... Ok!
0088 
0089 10. Check that file ends with a newline [endswithnewline]... Ok!
0090 
0091 11. Check for C++ ctors that should be declared 'explicit' [explicit]... 1 issue found
0092         ./libkstapp/datawizard.h: line#180 (1)
0093         Make all C++ class constructors that can be used with only one
0094         required argument 'explicit' to minimize wrong use of the class. Do
0095         this to avoid mistaken implicit constructor ambiguities. Copy
0096         constructors should not be explicit.
0097 
0098 12. Check for foreach loop issues [foreach]... 1 issue found
0099         ./libkstapp/formatgridhelper.cpp: non-const ref iterator line#204 (1)
0100         When not using POD types (int, double, pointer, ...) you should use
0101         const & for your foreach variables. There are two reasons for this:
0102         1) Prevents you from the mistake of writing foreach loops that
0103         modify the list, that is 'foreach(Foo f, list) f.a = f.b = f.c =
0104         0;' compiles but does not modify the contents of list 2) Saves a
0105         copy constructor call for each of the list elements
0106 
0107 13. Check validity of i18n calls [i18ncheckarg]... 124 issues found
0108         ./libkstmath/histogram.cpp: wrong argument count, have 0 need 3 line#412
0109         ./libkstmath/histogram.cpp: wrong argument count, have 0 need 1 line#210,302,408,414
0110         ./libkstmath/equation.cpp: wrong argument count, have 0 need 3 line#557
0111         ./libkstmath/equation.cpp: wrong argument count, have 0 need 1 line#157,182,232,239,241
0112         ./libkstmath/psd.cpp: wrong argument count, have 0 need 2 line#467
0113         ./libkstmath/psd.cpp: wrong argument count, have 0 need 1 line#475
0114         ./libkstmath/psd.cpp: single adjective as message, probably ambiguous; use context call to explain what it refers to line#471
0115         ./libkstmath/basicplugin.cpp: wrong argument count, have 0 need 1 line#233,388
0116         ./libkstmath/csd.cpp: wrong argument count, have 0 need 2 line#393
0117         ./libkstmath/csd.cpp: wrong argument count, have 0 need 1 line#195,401
0118         ./libkstmath/csd.cpp: single adjective as message, probably ambiguous; use context call to explain what it refers to line#397
0119         ./libkstmath/image.cpp: wrong argument count, have 0 need 1 line#142,799
0120         ./libkstmath/enodes.cpp: wrong argument count, have 0 need 1 line#753
0121         ./libkstmath/dataobject.cpp: wrong argument count, have 0 need 3 line#518
0122         ./libkstmath/eventmonitorentry.cpp: wrong argument count, have 0 need 1 line#442
0123         ./libkstmath/eventmonitorentry.cpp: reported ambiguous message by translators; use context call to explain what it refers to line#438,442
0124         ./libkstmath/curve.cpp: wrong argument count, have 0 need 2 line#388,1594,1619
0125         ./libkstmath/curve.cpp: wrong argument count, have 0 need 1 line#1603,1607,1611,1615,1623
0126         ./libkstmath/curve.cpp: wrong argument count, have 0 need 3 line#1600
0127         ./libkstmath/plotdefines.h: malformed markup (unmatched tags, etc.) line#63,64
0128         ./datasources/ascii/asciisource.cpp: wrong argument count, have 0 need 1 line#813
0129         ./plugins/fits/gaussian_weighted/fitgaussian_weighted.cpp: wrong argument count, have 0 need 1 line#236
0130         ./plugins/fits/lorentzian_weighted/fitlorentzian_weighted.cpp: wrong argument count, have 0 need 1 line#235
0131         ./plugins/fits/exponential_unweighted/fitexponential_unweighted.cpp: wrong argument count, have 0 need 1 line#216
0132         ./plugins/fits/polynomial_weighted/fitpolynomial_weighted.cpp: wrong argument count, have 0 need 1 line#213
0133         ./plugins/fits/gradient_weighted/fitgradient_weighted.cpp: wrong argument count, have 0 need 1 line#193
0134         ./plugins/fits/linear_unweighted/fitlinear_unweighted.cpp: wrong argument count, have 0 need 1 line#189
0135         ./plugins/fits/linear_weighted/fitlinear_weighted.cpp: wrong argument count, have 0 need 1 line#193
0136         ./plugins/fits/polynomial_unweighted/fitpolynomial_unweighted.cpp: wrong argument count, have 0 need 1 line#197
0137         ./plugins/fits/gradient_unweighted/fitgradient_unweighted.cpp: wrong argument count, have 0 need 1 line#177
0138         ./plugins/fits/exponential_weighted/fitexponential_weighted.cpp: wrong argument count, have 0 need 1 line#231
0139         ./plugins/fits/gaussian_unweighted/fitgaussian_unweighted.cpp: wrong argument count, have 0 need 1 line#221
0140         ./plugins/fits/lorentzian_unweighted/fitlorentzian_unweighted.cpp: wrong argument count, have 0 need 1 line#221
0141         ./plugins/fits/sinusoid_weighted/fitsinusoid_weighted.cpp: wrong argument count, have 0 need 1 line#238
0142         ./plugins/fits/sinusoid_unweighted/fitsinusoid_unweighted.cpp: wrong argument count, have 0 need 1 line#221
0143         ./plugins/filters/butterworth_bandstop/butterworth_bandstop.cpp: wrong argument count, have 0 need 1 line#222
0144         ./plugins/filters/despike/filterdespike.cpp: wrong argument count, have 0 need 1 line#155,283
0145         ./plugins/filters/despike/filterdespike.cpp: wrong argument count, have 0 need 3 line#153
0146         ./plugins/filters/differentiation/differentiation.cpp: wrong argument count, have 0 need 2 line#137
0147         ./plugins/filters/differentiation/differentiation.cpp: wrong argument count, have 0 need 1 line#139
0148         ./plugins/filters/cumulativesum/cumulativesum.cpp: wrong argument count, have 0 need 2 line#137
0149         ./plugins/filters/cumulativesum/cumulativesum.cpp: wrong argument count, have 0 need 1 line#139
0150         ./plugins/filters/butterworth_bandpass/butterworth_bandpass.cpp: wrong argument count, have 0 need 1 line#221
0151         ./plugins/filters/butterworth_lowpass/butterworth_lowpass.cpp: wrong argument count, have 0 need 1 line#194
0152         ./plugins/filters/butterworth_highpass/butterworth_highpass.cpp: wrong argument count, have 0 need 1 line#198
0153         ./widgets/labelbuilder.cpp: malformed markup (unmatched tags, etc.) line#24
0154         ./libkst/string_kst.cpp: wrong argument count, have 0 need 1 line#102
0155         ./libkst/datasource.cpp: single adjective as message, probably ambiguous; use context call to explain what it refers to line#76
0156         ./libkst/vscalar.cpp: wrong argument count, have 0 need 5 line#174
0157         ./libkst/vscalar.cpp: wrong argument count, have 0 need 4 line#207
0158         ./libkst/vector.cpp: wrong argument count, have 0 need 3 line#594
0159         ./libkst/vector.cpp: wrong argument count, have 0 need 1 line#590
0160         ./libkst/scalar.cpp: wrong argument count, have 0 need 2 line#139
0161         ./libkst/scalar.cpp: wrong argument count, have 0 need 1 line#156
0162         ./libkst/scalar.cpp: wrong argument count, have 0 need 3 line#137
0163         ./libkst/generatedvector.cpp: wrong argument count, have 0 need 3 line#93
0164         ./libkst/generatedvector.cpp: wrong argument count, have 0 need 4 line#88
0165         ./libkst/matrix.cpp: wrong argument count, have 0 need 3 line#625
0166         ./libkst/datastring.cpp: wrong argument count, have 0 need 2 line#170
0167         ./libkst/datastring.cpp: wrong argument count, have 0 need 4 line#161
0168         ./libkst/debug.cpp: wrong argument count, have 0 need 1 line#143
0169         ./libkst/datascalar.cpp: wrong argument count, have 0 need 3 line#166
0170         ./libkst/datascalar.cpp: wrong argument count, have 0 need 4 line#157
0171         ./libkst/datamatrix.cpp: wrong argument count, have 0 need 5 line#669
0172         ./libkst/datamatrix.cpp: wrong argument count, have 0 need 2 line#677
0173         ./libkst/datamatrix.cpp: wrong argument count, have 0 need 1 line#175
0174         ./libkst/datavector.cpp: wrong argument count, have 0 need 2 line#759
0175         ./libkst/datavector.cpp: wrong argument count, have 0 need 1 line#755,757,763,765
0176         ./libkst/datavector.cpp: wrong argument count, have 0 need 3 line#749
0177         ./libkst/datavector.cpp: wrong argument count, have 0 need 4 line#772
0178         ./libkst/editablevector.cpp: wrong argument count, have 0 need 2 line#84
0179         ./libkstapp/plotitem.cpp: wrong argument count, have 0 need 2 line#3435
0180         ./libkstapp/legenditem.cpp: wrong argument count, have 0 need 2 line#127,133,137,486
0181         ./libkstapp/datawizard.cpp: wrong argument count, have 0 need 2 line#833
0182         ./libkstapp/logdialog.cpp: wrong argument count, have 0 need 1 line#162
0183         ./libkstapp/debugdialog.cpp: wrong argument count, have 0 need 2 line#41
0184         ./libkstapp/debugdialog.cpp: wrong argument count, have 0 need 1 line#43
0185         ./libkstapp/plotrenderitem.cpp: wrong argument count, have 0 need 2 line#439
0186         ./libkstapp/commandlineparser.cpp: wrong argument count, have 0 need 1 line#439,482,523,563
0187         ./libkstapp/commandlineparser.cpp: malformed markup (unmatched tags, etc.) line#386,389,392,399,421,423,425,428,475,516,557,584,586,588
0188         ./libkstapp/logwidget.cpp: wrong argument count, have 0 need 3 line#57
0189         ./libkstapp/labelpropertiestab.cpp: malformed markup (unmatched tags, etc.) line#30
0190         ./libkstapp/plotaxis.cpp: reported ambiguous message by translators; use context call to explain what it refers to line#785
0191         Make the translators' job easier and detect problems in the usage
0192         of the i18n() calls. When the fix is not clear, check the Techbase
0193         article at
0194         <http://techbase.kde.org/Development/Tutorials/Localization/i18n_Kr
0195         azy> for more information.
0196 
0197 14. Check for invalid icon names [iconnames]... Ok!
0198 
0199 15. Check for proper include directives [includes]... 31 issues found
0200         ./libkstmath/escan.cpp: duplicate includes line#21,495(stdio.h);22,496(string.h);24,494(stdlib.h)
0201         ./libkstmath/kstmath_pch.h: missing or improper include guard in header
0202         ./libkstmath/emailthread.h: missing or improper include guard in header
0203         ./datasources/netcdf/netcdfplugin.h: missing or improper include guard in header
0204         ./datasources/netcdf/netcdfsource.h: missing or improper include guard in header
0205         ./datasources/netcdf/netcdfsource.cpp: include own header first line#23
0206         ./datasources/dmc/dmcobj.cpp: include own header first line#26
0207         ./datasources/dmc/dmcsource.h: duplicate includes line#21,25(datasource.h)
0208         ./datasources/dmc/dmcobj.h: missing or improper include guard in header
0209         ./plugins/fits/linear_weighted.h: missing or improper include guard in header
0210         ./plugins/fits/common.h: missing or improper include guard in header
0211         ./plugins/fits/non_linear_weighted.h: missing or improper include guard in header
0212         ./plugins/fits/linear.h: missing or improper include guard in header
0213         ./plugins/fits/non_linear.h: missing or improper include guard in header
0214         ./plugins/fits/kneefrequency/fitkneefrequency.h: missing or improper include guard in header
0215         ./plugins/filters/filters.h: missing or improper include guard in header
0216         ./plugins/dataobject/interpolations/interpolations.h: missing or improper include guard in header
0217         ./plugins/dataobject/lockin/iirfilter.h: using leading or trailing underscores on include guard in header
0218         ./widgets/kstwidgets_pch.h: missing or improper include guard in header
0219         ./libkst/kstcore_pch.h: missing or improper include guard in header
0220         ./libkst/kstcore_pch.h: do not include QtModules line#8(QtCore);9(QtGui);10(QtXml)
0221         ./libkst/stdinsource.cpp: include own header first line#20
0222         ./libkst/stdinsource.cpp: put config.h in angle brackets line#19
0223         ./libkst/timezones.h: using leading or trailing underscores on include guard in header
0224         ./libkst/stdinsource.h: missing or improper include guard in header
0225         ./libkstapp/overridelabeltab.h: missing or improper include guard in header
0226         ./libkstapp/kstapp_pch.h: missing or improper include guard in header
0227         Use <..> to include installed headers; <QtModule/QClass> to include
0228         Qt headers from installed headers; cpp file should include their
0229         own headers first (but below config.h); other rules apply, see
0230         <http://techbase.kde.org/Policies/Library_Code_Policy#Getting_.23in
0231         cludes_right>. Use include guards in headers with appropriatedly
0232         encoded macro names.
0233 
0234 16. Check for inline methods in public classes [inline]... Ok!
0235 
0236 17. Check for an acceptable license [license]... 10 issues found
0237         ./libkstmath/fftsg_h.c: missing license
0238         ./libkstmath/kstmath_pch.h: missing license
0239         ./datasources/ascii/kst_atof.h: missing license
0240         ./datasources/ascii/kst_atof.cpp: missing license
0241         ./kst/main-vld.cpp: missing license
0242         ./plugins/dataobject/genericfilter/polynom.h: missing license
0243         ./plugins/dataobject/genericfilter/filter.h: missing license
0244         ./plugins/dataobject/crossspectrum/fftsg_h.c: missing license
0245         ./widgets/kstwidgets_pch.h: missing license
0246         ./libkstapp/kstapp_pch.h: missing license
0247         Each source file must contain a license or a reference to a license
0248         which states under which terms the software may be used, modified
0249         and redistributed.  For details regarding KDE's licensing policy
0250         please visit <http://techbase.kde.org/Policies/Licensing_Policy>.
0251 
0252 18. Check for assignments to QString::null [nullstrassign]... 8 issues found
0253         ./datasources/lfiio/lfiio.cpp: line#32 (1)
0254         ./datasources/lfiio/lfiio.h: line#40 (1)
0255         ./datasources/healpix/healpix.h: line#44 (1)
0256         ./datasources/healpix/healpix.cpp: line#50 (1)
0257         ./datasources/planckIDEF/planckIDEF.cpp: line#35 (1)
0258         ./datasources/planckIDEF/planckIDEF.h: line#54 (1)
0259         ./libkst/stdinsource.cpp: line#159 (1)
0260         ./libkst/stdinsource.h: line#48 (1)
0261         Do not assign QString::null or QString() to a QString.  Instead use
0262         the .clear() method.  For example, "str = QString::null" becomes
0263         "str.clear()". When returning an empty string from a method use
0264         "return QString()"  When passing an empty string use "QString()".
0265 
0266 19. Check for compares to QString::null or QString() [nullstrcompare]... Ok!
0267 
0268 20. Check for C++ operators that should be 'const' [operators]... Ok!
0269 
0270 21. Check for inappropriate pass-by-value function args [passbyvalue]... Ok!
0271 
0272 22. Check for postfix usage of ++ and -- [postfixop]... 121 issues found
0273         ./d2asc/d2asc.cpp: line#62,66,104,117,126,127 (6)
0274         ./libkstmath/psdcalculator.cpp: line#194,214,223,227,231,235,239,243,247,251,262,287,294,300,306 (15)
0275         ./libkstmath/curve.cpp: line#525,1121,1133,1263,1353 (5)
0276         ./datasources/lfiio/lfiio.cpp: line#169,253,258,311,550 (5)
0277         ./datasources/healpix/healpix_tools_pix.cpp: line#83,87,765,771,776,782 (6)
0278         ./datasources/healpix/healpix_tools_fits.cpp: line#55,64,92,101 (4)
0279         ./datasources/fitsimage/fitsimage.cpp: line#328,329,335,336,342,343,349,350 (8)
0280         ./datasources/qimagesource/qimagesource.cpp: line#121,127,133,139 (4)
0281         ./datasources/ascii/asciisource.cpp: line#599 (1)
0282         ./datasources/planckIDEF/planckIDEF.cpp: line#315,375,528,623,746,814,1320 (7)
0283         ./datasources/dmc/dmcobj.cpp: line#302,349 (2)
0284         ./plugins/fits/gradient_weighted/fitgradient_weighted.cpp: line#219 (1)
0285         ./plugins/fits/linear_unweighted/fitlinear_unweighted.cpp: line#204 (1)
0286         ./plugins/fits/linear_weighted/fitlinear_weighted.cpp: line#221 (1)
0287         ./plugins/fits/gradient_unweighted/fitgradient_unweighted.cpp: line#202 (1)
0288         ./plugins/fits/kneefrequency/fitkneefrequency.cpp: line#277,292,315,320,325 (5)
0289         ./plugins/filters/despike/filterdespike.cpp: line#199,211,234,258 (4)
0290         ./plugins/dataobject/periodogram/periodogram.cpp: line#378,382,490,535,541,602,611,619,737,749,756,761,774 (13)
0291         ./plugins/dataobject/crossspectrum/crossspectrum.cpp: line#218,232,240,256,273,283 (6)
0292         ./plugins/dataobject/linefit/linefit.cpp: line#187,201,217 (3)
0293         ./widgets/scalarselector.cpp: line#146 (1)
0294         ./widgets/stringselector.cpp: line#74 (1)
0295         ./widgets/curveselector.cpp: line#62 (1)
0296         ./widgets/vectorselector.cpp: line#89 (1)
0297         ./libkst/vector.cpp: line#393,431,470 (3)
0298         ./libkst/matrix.cpp: line#218,227,230,238,247,255 (6)
0299         ./libkst/datavector.cpp: line#474,528,591 (3)
0300         ./libkst/timezones.cpp: line#746,750,755,761,786,791,796 (7)
0301         You should use ++ and -- as prefix whenever possible as these are
0302         more efficient than postfix operators. Prefix increments first and
0303         then uses the variable, postfix uses the actual; the variable is
0304         incremented as well. Because of this, the prefix operators are
0305         inherently more efficient. *WARNING* Make sure that you don't
0306         introduce off-by-one errors when changing i++ to ++i.
0307 
0308 23. Check for dangerous or inefficient QByteArray usage [qbytearray]... Ok!
0309 
0310 24. Check for Qt classes that should not be used [qclasses]... 57 issues found
0311         ./widgets/curveappearance.h: QComboBox[KComboBox] (1)
0312         ./widgets/labellineedit.cpp: QLineEdit[KLineEdit] (1)
0313         ./widgets/gradienteditor.cpp: QColorDialog[KColorDialog] (1)
0314         ./widgets/combobox.cpp: QLineEdit[KLineEdit] (1)
0315         ./widgets/filerequester.cpp: QLineEdit[KLineEdit],QFileDialog[KFileDialog],QFileDialog[KFileDialog],QFileDialog[KFileDialog] (4)
0316         ./widgets/datasourceselectordialog.cpp: QMessageBox[KMessageBox],QFileDialog[KFileDialog] (2)
0317         ./widgets/colorbutton.cpp: QColorDialog[KColorDialog] (1)
0318         ./widgets/datasourceselector.cpp: QLineEdit[KLineEdit] (1)
0319         ./widgets/datasourceselectordialog.h: QFileDialog[KFileDialog] (1)
0320         ./widgets/labellineedit.h: QLineEdit[KLineEdit] (1)
0321         ./widgets/curveappearance.cpp: QComboBox[KComboBox] (1)
0322         ./widgets/combobox.h: QComboBox[KComboBox] (1)
0323         ./libkst/datasourcepluginmanager.cpp: QUrl[KUrl] (1)
0324         ./libkstapp/datadialog.cpp: QLineEdit[KLineEdit] (1)
0325         ./libkstapp/pictureitem.cpp: QFileDialog[KFileDialog] (1)
0326         ./libkstapp/datawizard.cpp: QMessageBox[KMessageBox] (1)
0327         ./libkstapp/datamanager.cpp: QDialog[KDialog] (1)
0328         ./libkstapp/viewitemdialog.cpp: QLineEdit[KLineEdit] (1)
0329         ./libkstapp/debugdialog.cpp: QDialog[KDialog],QDialog[KDialog] (2)
0330         ./libkstapp/markerstab.cpp: QMessageBox[KMessageBox],QMessageBox[KMessageBox] (2)
0331         ./libkstapp/logwidget.h: QTextBrowser[KTextBrowser] (1)
0332         ./libkstapp/changefiledialog.cpp: QDialog[KDialog],QMessageBox[KMessageBox],QMessageBox[KMessageBox],QMessageBox[KMessageBox] (4)
0333         ./libkstapp/viewvectordialog.cpp: QDialog[KDialog] (1)
0334         ./libkstapp/exportvectorsdialog.cpp: QDialog[KDialog] (1)
0335         ./libkstapp/viewmatrixdialog.cpp: QDialog[KDialog] (1)
0336         ./libkstapp/commandlineparser.cpp: QMessageBox[KMessageBox] (1)
0337         ./libkstapp/filterfitdialog.cpp: QMessageBox[KMessageBox] (1)
0338         ./libkstapp/dialog.cpp: QDialog[KDialog] (1)
0339         ./libkstapp/view.cpp: QInputDialog[KInputDialog] (1)
0340         ./libkstapp/changedatasampledialog.cpp: QDialog[KDialog] (1)
0341         ./libkstapp/differentiatecurvesdialog.cpp: QDialog[KDialog] (1)
0342         ./libkstapp/mainwindow.cpp: QMessageBox[KMessageBox],QFileDialog[KFileDialog],QMessageBox[KMessageBox],QFileDialog[KFileDialog],QMessageBox[KMessageBox] (5)
0343         ./libkstapp/basicplugindialog.cpp: QMessageBox[KMessageBox] (1)
0344         ./libkstapp/dialogpage.cpp: QTabWidget[KTabWidget] (1)
0345         ./libkstapp/viewitem.cpp: QInputDialog[KInputDialog] (1)
0346         ./libkstapp/svgitem.cpp: QFileDialog[KFileDialog] (1)
0347         ./libkstapp/tabwidget.h: QTabWidget[KTabWidget] (1)
0348         ./libkstapp/tabwidget.cpp: QTabBar[KTabBar],QTabBar[KTabBar],QInputDialog[KInputDialog],QTabBar[KTabBar] (4)
0349         ./libkstapp/choosecolordialog.cpp: QDialog[KDialog],QLineEdit[KLineEdit],QLineEdit[KLineEdit] (3)
0350         Don't use Qt 4 classes that are deprecated. Additionally make sure
0351         to use the KDE version of some Qt GUI elements to provide a
0352         consistent look and feel for the KDE desktop. The KDE classes are
0353         not just adding functionalities to the Qt base class and are mostly
0354         not even based on the Qt class.
0355         <http://techbase.kde.org/Policies/API_to_Avoid> *Please* *refer*
0356         *to* *the* *API* *documentation* *for* *details* *before* *porting*
0357         *to* *the* *K* *classes*.
0358 
0359 25. Check for Qt methods that should be avoided [qmethods]... Ok!
0360 
0361 26. Check for QMIN and QMAX macros [qminmax]... Ok!
0362 
0363 27. Check for classes that should use the 'Q_OBJECT' macro [qobject]... Ok!
0364 
0365 28. Check for signals: and slots: [sigsandslots]... Ok!
0366 
0367 29. Check for spelling errors [spelling]... 7 issues found
0368         ./datasources/dmc/dmcdata.cpp: line#51[dont] (1)
0369         ./plugins/sampleplugin/sampleplugin.cpp: line#93[everytime],104[everytime],145[occured] (3)
0370         ./plugins/dataobject/genericfilter/polynom.h: line#60[acces] (1)
0371         ./libkst/timezones.h: line#206[customised] (1)
0372         ./libkst/timezones.cpp: line#777[abbrevations] (1)
0373         Spelling errors in comments and strings should be fixed as they may
0374         show up later in API documentation, handbooks, etc.  Misspelled
0375         strings make the translator's job harder. Please use US English.
0376 
0377 30. Check for strings used improperly or should be i18n. [strings]... 36 issues found
0378         ./libkstmath/labelparser.cpp: QLatin1String issues line#210,214,225,229,239,243,247,257,261,275,279,283,293,297,337,349,353,357,371,375,379,383,397,414,426,438,442,460,464,468,478,490 (32)
0379         ./libkst/datasourcepluginmanager.cpp: QLatin1String issues line#169 (1)
0380         ./libkst/timezones.cpp: QLatin1String issues line#594 (1)
0381         ./libkstapp/document.cpp: QLatin1String issues line#63 (1)
0382         ./libkstapp/commandlineparser.cpp: QLatin1String issues line#604 (1)
0383         Some QString methods (like startsWith() and endsWith()) are more
0384         efficient if they are passed a QLatin1String, avoiding an implicit
0385         conversion from const char *.
0386 
0387 31. Check for system calls to replace by KDE or Qt equivalents [syscalls]... 6 issues found
0388         ./datasources/dmc/dmcdata.cpp: line#33 getenv[qgetenv] (1)
0389         ./libkst/timezones.cpp: line#276 getenv[qgetenv],325 getenv[qgetenv],422 getenv[qgetenv],518 getenv[qgetenv] (4)
0390         ./libkstapp/document.cpp: line#148 open[KDE_open] (1)
0391         Some system calls are not portable, please use the suggested
0392         portable wrapper instead. See kde_file.h
0393 
0394 32. Check for typedefs that should be replaced by Qt typedefs [typedefs]... 3 issues found
0395         ./libkstmath/escan.cpp: line#45 int8_t[qint8],#47 int16_t[qint16],#49 int32_t[qint32] (3)
0396         Please use Qt typedefs (like qint32 and qreal) as defined in
0397         QGlobals. These typedefs are guaranteed to have the size in bits
0398         that the name states on all platforms. 
0399 
0400 ==>For File Type desktop<==
0401 1. Check that file ends with a newline [endswithnewline]... Ok!
0402 
0403 2. Check for invalid icon names [iconnames]... Ok!
0404 
0405 3. Check for spelling errors [spelling]... Ok!
0406 
0407 4. Validates desktop files using 'desktop-file-validate' [validate]... 9 issues found
0408         ./kst/kst2.desktop: key "DocPath" in group "Desktop Entry" is a reserved key for KDE
0409         ./kst/kst2.desktop: (will be fatal in the future): value "Science" in key "Categories" in group "Desktop Entry" requires another category to be present among the following categories: Education
0410         ./kst/kst2.desktop: (will be fatal in the future): value "Qt;KDE;Science;" for key "Categories" in group "Desktop Entry" does not contain a registered main category
0411         ./kst/kst2.desktop: key "Encoding" in group "Desktop Entry" is deprecated
0412         ./kst/x-kst2.desktop: value "MimeType" for key "Type" in group "Desktop Entry" is deprecated
0413         ./kst/x-kst2.desktop: value "application/x-kst" for string list key "MimeType" in group "Desktop Entry" does not have a semicolon (';') as trailing character
0414         ./kst/x-kst2.desktop: key "DefaultApp" in group "Desktop Entry" is deprecated
0415         ./kst/x-kst2.desktop: key "Patterns" in group "Desktop Entry" is deprecated
0416         ./kst/x-kst2.desktop: required key "Name" in group "Desktop Entry" is not present
0417         Please make sure your .desktop files conform to the freedesktop.org
0418         standard. See the spec at
0419         <http://standards.freedesktop.org/desktop-entry-spec/latest>
0420 
0421 ==>For File Type designer<==
0422 1. Check that file ends with a newline [endswithnewline]... Ok!
0423 
0424 2. Check for files that need to be fixed by 'fixuifiles' [fixuifiles]... 14 issues found
0425         ./libkstapp/labeltab.ui: fixuifiles needs to be run on this file
0426         ./libkstapp/labelpropertiestab.ui: fixuifiles needs to be run on this file
0427         ./libkstapp/overridelabeltab.ui: fixuifiles needs to be run on this file
0428         ./libkstapp/labelcreator.ui: fixuifiles needs to be run on this file
0429         ./libkstapp/legendtab.ui: fixuifiles needs to be run on this file
0430         ./libkstapp/datawizardpagevectors.ui: fixuifiles needs to be run on this file
0431         ./libkstapp/contenttab.ui: fixuifiles needs to be run on this file
0432         Please run the trunk/kdesdk/fixuifiles on all your .ui files as
0433         there are some artifacts created by Qt designer that are
0434         undesireable for KDE.
0435 
0436 3. Check validity of i18n calls [i18ncheckarg]... 57 issues found
0437         ./datasources/healpix/healpixconfig.ui: reported ambiguous message by translators; use context call to explain what it refers to line#34
0438         ./plugins/fits/gaussian_weighted/fitgaussian_weightedconfig.ui: reported ambiguous message by translators; use context call to explain what it refers to line#29
0439         ./plugins/fits/exponential_unweighted/fitexponential_unweightedconfig.ui: reported ambiguous message by translators; use context call to explain what it refers to line#31
0440         ./plugins/fits/gradient_weighted/fitgradient_weightedconfig.ui: reported ambiguous message by translators; use context call to explain what it refers to line#29
0441         ./plugins/fits/linear_unweighted/fitlinear_unweightedconfig.ui: reported ambiguous message by translators; use context call to explain what it refers to line#31
0442         ./plugins/fits/polynomial_unweighted/fitpolynomial_unweightedconfig.ui: reported ambiguous message by translators; use context call to explain what it refers to line#31
0443         ./plugins/fits/gradient_unweighted/fitgradient_unweightedconfig.ui: reported ambiguous message by translators; use context call to explain what it refers to line#31
0444         ./plugins/fits/exponential_weighted/fitexponential_weightedconfig.ui: reported ambiguous message by translators; use context call to explain what it refers to line#23
0445         ./plugins/fits/gaussian_unweighted/fitgaussian_unweightedconfig.ui: reported ambiguous message by translators; use context call to explain what it refers to line#31
0446         ./plugins/fits/lorentzian_unweighted/fitlorentzian_unweightedconfig.ui: reported ambiguous message by translators; use context call to explain what it refers to line#31
0447         ./plugins/fits/sinusoid_unweighted/fitsinusoid_unweightedconfig.ui: reported ambiguous message by translators; use context call to explain what it refers to line#29
0448         ./widgets/fftoptions.ui: reported ambiguous message by translators; use context call to explain what it refers to line#44
0449         ./widgets/matrixselector.ui: reported ambiguous message by translators; use context call to explain what it refers to line#27
0450         ./widgets/scalarlistselector.ui: reported ambiguous message by translators; use context call to explain what it refers to line#41
0451         ./widgets/vectorselector.ui: reported ambiguous message by translators; use context call to explain what it refers to line#33
0452         ./widgets/curveappearance.ui: reported ambiguous message by translators; use context call to explain what it refers to line#296
0453         ./widgets/curveappearance.ui: single adjective as message, probably ambiguous; use context call to explain what it refers to line#198,301,306,311
0454         ./libkstapp/generaltab.ui: reported ambiguous message by translators; use context call to explain what it refers to line#14
0455         ./libkstapp/dialogpage.ui: reported ambiguous message by translators; use context call to explain what it refers to line#13
0456         ./libkstapp/matrixtab.ui: single adjective as message, probably ambiguous; use context call to explain what it refers to line#670
0457         ./libkstapp/stroketab.ui: reported ambiguous message by translators; use context call to explain what it refers to line#14
0458         ./libkstapp/markerstab.ui: reported ambiguous message by translators; use context call to explain what it refers to line#14
0459         ./libkstapp/editmultiplewidget.ui: single adjective as message, probably ambiguous; use context call to explain what it refers to line#66
0460         ./libkstapp/filltab.ui: reported ambiguous message by translators; use context call to explain what it refers to line#20
0461         ./libkstapp/defaultlabelpropertiestab.ui: reported ambiguous message by translators; use context call to explain what it refers to line#14,164
0462         ./libkstapp/labeltab.ui: reported ambiguous message by translators; use context call to explain what it refers to line#14
0463         ./libkstapp/layouttab.ui: reported ambiguous message by translators; use context call to explain what it refers to line#14
0464         ./libkstapp/dimensionstab.ui: reported ambiguous message by translators; use context call to explain what it refers to line#14
0465         ./libkstapp/labelpropertiestab.ui: reported ambiguous message by translators; use context call to explain what it refers to line#17
0466         ./libkstapp/labelpropertiestab.ui: single adjective as message, probably ambiguous; use context call to explain what it refers to line#70,89
0467         ./libkstapp/logdialog.ui: single adjective as message, probably ambiguous; use context call to explain what it refers to line#92
0468         ./libkstapp/arrowpropertiestab.ui: reported ambiguous message by translators; use context call to explain what it refers to line#17
0469         ./libkstapp/histogramtab.ui: reported ambiguous message by translators; use context call to explain what it refers to line#111
0470         ./libkstapp/rangetab.ui: reported ambiguous message by translators; use context call to explain what it refers to line#14
0471         ./libkstapp/childviewoptionstab.ui: reported ambiguous message by translators; use context call to explain what it refers to line#14
0472         ./libkstapp/gridtab.ui: reported ambiguous message by translators; use context call to explain what it refers to line#14
0473         ./libkstapp/overridelabeltab.ui: reported ambiguous message by translators; use context call to explain what it refers to line#20
0474         ./libkstapp/labelcreator.ui: reported ambiguous message by translators; use context call to explain what it refers to line#80
0475         ./libkstapp/labelcreator.ui: single adjective as message, probably ambiguous; use context call to explain what it refers to line#87,103
0476         ./libkstapp/axistab.ui: reported ambiguous message by translators; use context call to explain what it refers to line#14
0477         ./libkstapp/imagetab.ui: reported ambiguous message by translators; use context call to explain what it refers to line#14
0478         ./libkstapp/viewprimitivedialog.ui: reported ambiguous message by translators; use context call to explain what it refers to line#25
0479         ./libkstapp/legendtab.ui: reported ambiguous message by translators; use context call to explain what it refers to line#19
0480         ./libkstapp/differentiatecurvesdialog.ui: reported ambiguous message by translators; use context call to explain what it refers to line#245
0481         ./libkstapp/differentiatecurvesdialog.ui: single adjective as message, probably ambiguous; use context call to explain what it refers to line#110,130,250,255,260
0482         ./libkstapp/eventmonitortab.ui: reported ambiguous message by translators; use context call to explain what it refers to line#169
0483         ./libkstapp/eventmonitortab.ui: single adjective as message, probably ambiguous; use context call to explain what it refers to line#199
0484         Make the translators' job easier and detect problems in the usage
0485         of the i18n() calls. When the fix is not clear, check the Techbase
0486         article at
0487         <http://techbase.kde.org/Development/Tutorials/Localization/i18n_Kr
0488         azy> for more information.
0489 
0490 4. Check for Qt classes that should not be used [qclasses]... 88 issues found
0491         ./datasources/healpix/healpixconfig.ui: QComboBox[KComboBox],QLineEdit[KLineEdit],QLineEdit[KLineEdit],QComboBox[KComboBox],QLineEdit[KLineEdit],QLineEdit[KLineEdit],QComboBox[KComboBox],QComboBox[KComboBox],QLineEdit[KLineEdit] (9)
0492         ./datasources/ascii/asciiconfig.ui: QLineEdit[KLineEdit],QLineEdit[KLineEdit],QLineEdit[KLineEdit],QComboBox[KComboBox],QComboBox[KComboBox] (5)
0493         ./widgets/fftoptions.ui: QComboBox[KComboBox],QLineEdit[KLineEdit],QLineEdit[KLineEdit],QLineEdit[KLineEdit],QComboBox[KComboBox] (5)
0494         ./widgets/scalarlistselector.ui: QLineEdit[KLineEdit] (1)
0495         ./widgets/curveplacement.ui: QComboBox[KComboBox] (1)
0496         ./widgets/datarange.ui: QLineEdit[KLineEdit],QLineEdit[KLineEdit],QComboBox[KComboBox],QComboBox[KComboBox] (4)
0497         ./widgets/colorpalette.ui: QComboBox[KComboBox] (1)
0498         ./widgets/curveappearance.ui: QComboBox[KComboBox],QComboBox[KComboBox],QComboBox[KComboBox],QComboBox[KComboBox],QComboBox[KComboBox] (5)
0499         ./libkstapp/vectortab.ui: QLineEdit[KLineEdit],QLineEdit[KLineEdit],QComboBox[KComboBox] (3)
0500         ./libkstapp/dialogpage.ui: QTabWidget[KTabWidget] (1)
0501         ./libkstapp/matrixtab.ui: QLineEdit[KLineEdit],QLineEdit[KLineEdit],QLineEdit[KLineEdit],QLineEdit[KLineEdit],QLineEdit[KLineEdit],QLineEdit[KLineEdit] (6)
0502         ./libkstapp/stroketab.ui: QComboBox[KComboBox],QComboBox[KComboBox],QComboBox[KComboBox],QComboBox[KComboBox] (4)
0503         ./libkstapp/markerstab.ui: QLineEdit[KLineEdit],QComboBox[KComboBox] (2)
0504         ./libkstapp/editmultiplewidget.ui: QLineEdit[KLineEdit] (1)
0505         ./libkstapp/filltab.ui: QComboBox[KComboBox] (1)
0506         ./libkstapp/defaultlabelpropertiestab.ui: QComboBox[KComboBox] (1)
0507         ./libkstapp/filterfittab.ui: QComboBox[KComboBox] (1)
0508         ./libkstapp/exportgraphicsdialog.ui: QComboBox[KComboBox] (1)
0509         ./libkstapp/logdialog.ui: QTabWidget[KTabWidget],QComboBox[KComboBox],QComboBox[KComboBox],QLineEdit[KLineEdit],QLineEdit[KLineEdit] (5)
0510         ./libkstapp/histogramtab.ui: QLineEdit[KLineEdit],QLineEdit[KLineEdit] (2)
0511         ./libkstapp/aboutdialog.ui: QTextBrowser[KTextBrowser] (1)
0512         ./libkstapp/rangetab.ui: QLineEdit[KLineEdit],QLineEdit[KLineEdit],QLineEdit[KLineEdit],QLineEdit[KLineEdit],QLineEdit[KLineEdit],QLineEdit[KLineEdit] (6)
0513         ./libkstapp/axistab.ui: QComboBox[KComboBox],QComboBox[KComboBox],QComboBox[KComboBox],QComboBox[KComboBox],QComboBox[KComboBox] (5)
0514         ./libkstapp/imagetab.ui: QLineEdit[KLineEdit],QLineEdit[KLineEdit] (2)
0515         ./libkstapp/stringtab.ui: QLineEdit[KLineEdit] (1)
0516         ./libkstapp/scalartab.ui: QLineEdit[KLineEdit],QLineEdit[KLineEdit] (2)
0517         ./libkstapp/legendtab.ui: QLineEdit[KLineEdit] (1)
0518         ./libkstapp/debugdialog.ui: QTabWidget[KTabWidget] (1)
0519         ./libkstapp/datawizardpagedatasource.ui: QComboBox[KComboBox] (1)
0520         ./libkstapp/equationtab.ui: QComboBox[KComboBox],QLineEdit[KLineEdit] (2)
0521         ./libkstapp/datawizardpagevectors.ui: QLineEdit[KLineEdit] (1)
0522         ./libkstapp/differentiatecurvesdialog.ui: QComboBox[KComboBox] (1)
0523         ./libkstapp/eventmonitortab.ui: QLineEdit[KLineEdit],QComboBox[KComboBox],QLineEdit[KLineEdit],QLineEdit[KLineEdit],QTextEdit[KTextEdit] (5)
0524         Don't use Qt 4 classes that are deprecated. Additionally make sure
0525         to use the KDE version of some Qt GUI elements to provide a
0526         consistent look and feel for the KDE desktop. The KDE classes are
0527         not just adding functionalities to the Qt base class and are mostly
0528         not even based on the Qt class.
0529         <http://techbase.kde.org/Policies/API_to_Avoid> *Please* *refer*
0530         *to* *the* *API* *documentation* *for* *details* *before* *porting*
0531         *to* *the* *K* *classes*.
0532 
0533 5. Check for spelling errors [spelling]... Ok!
0534 
0535 ==>For File Type kpartgui<==
0536 1. Check that file ends with a newline [endswithnewline]... Ok!
0537 
0538 2. Check validity of i18n calls [i18ncheckarg]... Ok!
0539 
0540 3. Check for spelling errors [spelling]... Ok!
0541 
0542 4. Validates kpartgui files using 'xmllint' [validate]... 1 issue found
0543         ./kst/kst_icon.rc: 1: parser error : Start tag expected, '<' not found
0544         Please make sure your .rc files conform to the XSD schema found in
0545         kdelibs/kdeui/xmlgui/kxmlgui.xsd
0546